Fix LinkNode paths for getTypeManifestVisitor #284
Merged
+110
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 452424e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Nov 4, 2024
Member
Author
This was referenced Nov 4, 2024
lorisleiva
force-pushed
the
loris/fix-link-node-path-for-unwrap-type-visitor
branch
from
89f1a82 to
20cceb8
Compare
lorisleiva
force-pushed
the
loris/fix-link-node-path-for-type-manifest-visitors
branch
from
57fc24c to
c5bb297
Compare
Merged
Member
Author
lorisleiva
changed the base branch from
loris/fix-link-node-path-for-unwrap-type-visitor
to
graphite-base/284
lorisleiva
force-pushed
the
loris/fix-link-node-path-for-type-manifest-visitors
branch
from
c5bb297 to
452424e
Compare
lorisleiva
deleted the
loris/fix-link-node-path-for-type-manifest-visitors
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the JavaScript
getTypeManifestVisitorswhere complex link node paths would be incorrectly resolved due to the fact that theNodeStackwould follow in invalid path in the tree. The new methods to save and restoreNodePathsinside theNodeStackhelp us fix this.